-
Notifications
You must be signed in to change notification settings - Fork 223
Feat Cross App CallActivity #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Note, this PR should be cherrypicked into the release branch once merged. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
This PR is also dependent on the dapr release for 1.16. Javi has a PR to update to the latest rc version here. We will need both merged in, then cherrypick both to the release branch |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
I need to release durabletask-java with this PR merged in before this current PR will be green |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle I was looking at this PR, but it doesn't have anything related to cross app call activity. |
Did you by chance read the thorough readme updates I added? |
I just got a workflow IT test locally 🎉 Need to cleanup and push, will do that + fix the conflict in my morning. Please feel free to review everything else and know I will update the pom.xml in my morning and add an IT test. Ill remove the mechanical markdown since Ill be adding the IT test. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cicoyle I've left a bunch of comments and suggestions. I am really against adding support for customHttp
and customGrpc
ports that is something that users shouldn't need to do as that goes against the idea of using containers that are started with random ports, but still allow the user to obtain the mapped ports to connect to them.
.withWorkingDirectory("/app") | ||
.withCommand("java", "-cp", "/app/classes:/app/libs/*", | ||
"-Ddapr.app.id=app2", | ||
"-Ddapr.grpc.endpoint=app2-sidecar:50002", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cicoyle here you can use the Testcontainers mapped (random) port instead of relying on a custom port number.
.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java
Outdated
Show resolved
Hide resolved
.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java
Outdated
Show resolved
Hide resolved
.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java
Outdated
Show resolved
Hide resolved
.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java
Show resolved
Hide resolved
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cicoyle overall the example looks good and the new additions for Cross App Call are good, but I believe that all the changes in the DaprContainer class will cause issues. I am curious to see what are the issues that you are facing if you don't introduce any change in that class.
DaprContainer is a critical class being used by customers now, so I would change the behavior of it.
My recommendation would be to revert the changes on DaprContainer
and I can help you to figure out what is going wrong with the containers when the pipelines fail.
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle codecov is still failing and sb 3.3.x was cancelled for some reason, I think the changes in the PR are ok if the pipelines and codecov are green. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
I pushed a test that should appease codecov. I also upped the test timeout to unblock this PR. I will open an issue to parallelize the test suite a bit bc it should not take this long. |
|
||
**Important Limitations:** | ||
- **Cross-app calls are currently supported for activities only** | ||
- **Child workflow cross-app calls (suborchestration) are NOT supported** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was added to dapr after this doc was created - may want to remove this limitation before merging - just happened to catch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1468 +/- ##
============================================
+ Coverage 76.91% 78.77% +1.86%
- Complexity 1592 1928 +336
============================================
Files 145 237 +92
Lines 4843 5946 +1103
Branches 562 610 +48
============================================
+ Hits 3725 4684 +959
- Misses 821 939 +118
- Partials 297 323 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add support for cross app call activity calls.