Skip to content

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Aug 28, 2025

This pr includes:

  • Use stored cert from resources folder to avoid importing bouncy castle library just for tests
  • Ci: Split unit test to its own job so we can run them in parallel and shorten all the cycle in around 5 minutes

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1528

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

This will avoid importing bouncy castle library just for tests

Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga marked this pull request as ready for review August 28, 2025 16:43
@javier-aliaga javier-aliaga requested review from a team as code owners August 28, 2025 16:43
@javier-aliaga
Copy link
Contributor Author

Question, how can we make the new Build/Unit tests job required?

@javier-aliaga javier-aliaga changed the title chore: Read test certs from resources folder Fix CVEs Aug 29, 2025
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM amazing PR, we are removing tech debt!

@salaboy salaboy merged commit e25f52a into dapr:master Aug 29, 2025
10 checks passed
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (d759c53) to head (8c848ed).
⚠️ Report is 208 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1529      +/-   ##
============================================
+ Coverage     76.91%   78.70%   +1.79%     
- Complexity     1592     1924     +332     
============================================
  Files           145      237      +92     
  Lines          4843     5932    +1089     
  Branches        562      610      +48     
============================================
+ Hits           3725     4669     +944     
- Misses          821      941     +120     
- Partials        297      322      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVEs in Dapr SDK version 1.16.0-rc-1
2 participants