Open
Conversation
|
Running this pull-request + TacoTip latest version (0.4.5) and seem to work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for your work on this addon.
I managed to get this working with TBC Anniversary with a few changes. Here's a screenshot, searching for one of the newly added items.
I'm not sure how you do releases so I've only changed the version in the TBC specific TOC file.
The diff is huge but the majority are from updating the Ace libraries that were vendored in 185d510.
This PR:
Just want to note that I did get some performance issues when combining this addon with TacoTip. Couldn't figure out what was going on so just disabled TacoTip.