Fix notification & add CHANGE_FOLDER notification#135
Open
drdada wants to merge 2 commits intodarickc:masterfrom
Open
Fix notification & add CHANGE_FOLDER notification#135drdada wants to merge 2 commits intodarickc:masterfrom
drdada wants to merge 2 commits intodarickc:masterfrom
Conversation
Quick and dirty fix to make the notification working again. It redirect all the notification to the socketnotification Should be temporary. Rework needed
This was referenced Aug 25, 2023
Contributor
|
Thanks for the PR! In the meantime there have been some changes to the code. Can you check if the notification problem still exists? |
|
There were some more changes, but lots of notifications still don't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notification fix is quick and dirty style.
Full code review have to be done.