v1.20.0 #109
Merged
v1.20.0 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary solution since we are still printing aa if the user window size is at single base resolution or bigger. If the window size is smaller than single base (1 terminal char spans more than one nt) we should instead adapt the protein sequence and show start and stop codons. Also: Fix test failing due to incorrect chrom; reformat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New in 1.20.0
--fasta/-faoption toread the reference fasta file. If
--fasta/-fais unset, ASCIIGenome willattempt the find a fasta file in the input file list. So these are all ok: