modified imageLoad and imageLoadHdr to also accept files with the #?RGBE identifier#32
Open
jtsiomb wants to merge 1 commit intodariomanesku:masterfrom
jtsiomb:master
Open
modified imageLoad and imageLoadHdr to also accept files with the #?RGBE identifier#32jtsiomb wants to merge 1 commit intodariomanesku:masterfrom jtsiomb:master
jtsiomb wants to merge 1 commit intodariomanesku:masterfrom
jtsiomb:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two different identifiers commonly used in HDR files. One is #?RADIANCE which is also shared by other file formats used by the radiance renderer, and the other is #?RGBE, which is more unambiguous.
I modified imageLoad and imageLoadHdr to recognize and accept both. I've also added a define to select on compile-time which one of the identifiers should be used when outputting HDR files.