add ship formation selector #389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
requested changes
Apr 13, 2025
src/main/java/com/github/manolo8/darkbot/core/manager/HeroManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/manolo8/darkbot/core/manager/HeroManager.java
Outdated
Show resolved
Hide resolved
|
|
||
| private Formation formation; | ||
|
|
||
| private final JComboBox<Formation> comboBox = new JComboBox<>(Formation.values()); |
Member
There was a problem hiding this comment.
Ideally instead of a dropdown with enum names, could use a set of icons for the formations and show the name as the tooltip
Contributor
Author
There was a problem hiding this comment.
that would be cleaner, maybe can be a follow up PR if someone can make the icons
src/main/java/com/github/manolo8/darkbot/gui/tree/editors/NewShipModeEditor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/manolo8/darkbot/gui/utils/table/FormationNpcInfoEditor.java
Show resolved
Hide resolved
anjeshshrestha
force-pushed
the
ship-formation
branch
from
b8ddbac to
8e5e697
Compare
Pablete1234
reviewed
Apr 13, 2025
Pablete1234
reviewed
Apr 13, 2025
src/main/java/com/github/manolo8/darkbot/core/manager/HeroManager.java
Outdated
Show resolved
Hide resolved
Pablete1234
reviewed
Apr 13, 2025
src/main/java/com/github/manolo8/darkbot/core/manager/HeroManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add formation selector for config, reduce key dependency to free up slotbar
CleanShot.2025-03-14.at.12.16.47.mp4