Fix to use Dart 2 core library lowercase constant names.

changelog.md

@@ -1,5 +1,8 @@
 # Changelog - chrome.dart
 
+## 0.10.2 2018-07-13
+- change core library constants to lowercase.
+
 ## 0.10.1 2018-05-02
 - fix missing classes on generated `app.dart` file.
 
@@ -98,11 +101,11 @@
 
 ## 0.5.2 2014-02-14 (SDK 1.3.0-dev.3.2 r33495)
 
-- Updated to use docgen for api documentation 
+- Updated to use docgen for api documentation
 - Make the window close event sync instead of async
 - Clean up warnings in unit tests
 - Add app/ to drone_io.sh script
-- Add a chrome pub transformer  
+- Add a chrome pub transformer
 - Fix an issue w/ the hand-overridden API
 - Use a getter to fetch the JsObject for an API each time it is needed
 

lib/src/common.dart

@@ -42,7 +42,7 @@ List listify(JsObject obj, [Function transformer = null]) {
 
 Map mapify(JsObject obj) {
   if (obj == null) return null;
-  return JSON.decode(_jsJSON.callMethod('stringify', [obj]));
+  return jsonDecode(_jsJSON.callMethod('stringify', [obj]));
 }
 
 dynamic jsify(dynamic obj) {

pubspec.yaml

@@ -1,8 +1,8 @@
 name: chrome
-version: 0.10.1
+version: 0.10.2
 authors:
 - Adam Bender <adambender@gmail.com>
-- Ben Holtz <bholtz@cs.stanford.edu> 
+- Ben Holtz <bholtz@cs.stanford.edu>
 description: A library for accessing the Chrome APIs in a packaged app or extension.
 homepage: https://github.com/dart-gde/chrome.dart
 environment:

tool/lib/gen_apis.dart

@@ -49,7 +49,7 @@ class GenApis {
   void generate() {
     _logger.info("reading ${apisFile.path}...");
 
-    var apisInfo = JSON.decode(apisFile.readAsStringSync());
+    var apisInfo = jsonDecode(apisFile.readAsStringSync());
 
     _generateApi('app', apisInfo['packaged_app'], includeAppSrc: true);
     _generateApi('ext', apisInfo['extension'], alreadyWritten: apisInfo['packaged_app']);

tool/lib/json_parser.dart

@@ -30,7 +30,7 @@ JsonNamespace parse(String jsonText) {
     }
   });
 
-  return _parseJson(JSON.decode(newLines.join('\n')));
+  return _parseJson(jsonDecode(newLines.join('\n')));
 }
 
 JsonNamespace _parseJson(dynamic json) {

tool/lib/overrides.dart

@@ -21,7 +21,7 @@ class Overrides {
   }
 
   Overrides.fromFile(File file) {
-    _init(JSON.decode(file.readAsStringSync()));
+    _init(jsonDecode(file.readAsStringSync()));
   }
 
   void _init(Map m) {

tool/src/googlesource.dart

@@ -23,7 +23,8 @@ abstract class GoogleSourceEntity {
 class GoogleSourceFile extends GoogleSourceEntity {
   static const _encodedCharacters = const ['\'', '&', '<', '>', '\"'];
   static final encodings =
-      new Map.fromIterable(_encodedCharacters, key: HTML_ESCAPE.convert);
+      new Map<String, String>.fromIterable(_encodedCharacters,
+          key: htmlEscape.convert);
 
   GoogleSourceFile(rawHtml, url) : super(rawHtml, url);
 

tool/src/simple_http_client.dart

@@ -16,6 +16,6 @@ class SimpleHttpClient {
     HttpClientRequest request = await _client.getUrl(uri);
     request.close();
     HttpClientResponse response = await request.done;
-    return await response.transform(UTF8.decoder).join('');
+    return await response.transform(utf8.decoder).join('');
   }
 }

tool/test/googlesource_test.dart

@@ -35,7 +35,7 @@ void defineTests() {
     test('unescapes files', () {
       var testEscapeString = 'this & that is <\"\'>';
       var escapedHtmlFile = '<table><tr><td></td><td><a name="1"></a><span>'
-          '${HTML_ESCAPE.convert(testEscapeString)}</span></td></tr></table>';
+          '${htmlEscape.convert(testEscapeString)}</span></td></tr></table>';
       file = new GoogleSourceFile(escapedHtmlFile, 'www.example.com');
 
       expect(file.fileContents, testEscapeString);

tool/test/model_json_test.dart

@@ -76,7 +76,7 @@ void main() {
         "description": "A simple enum with two values",
         "enum": ["firstVal", "secondVal"]
       }]''';
-      var jsonEnum = json_model.JsonEnum.parse(JSON.decode(data)).single;
+      var jsonEnum = json_model.JsonEnum.parse(jsonDecode(data)).single;
 
       expect(jsonEnum.name, 'simpleEnum');
       expect(jsonEnum.values.length, 2);
@@ -98,7 +98,7 @@ void main() {
         "description": "A very simple enum with one value",
         "enum": ["onlyVal"]
       }]''';
-      var jsonEnums = json_model.JsonEnum.parse(JSON.decode(data));
+      var jsonEnums = json_model.JsonEnum.parse(jsonDecode(data));
 
       expect(jsonEnums.length, 2);
       expect(jsonEnums[0].name, 'simpleEnum');
@@ -124,7 +124,7 @@ void main() {
         "description": "A very simple enum with one value",
         "enum": ["onlyVal"]
       }]''';
-      var jsonEnums = json_model.JsonEnum.parse(JSON.decode(data));
+      var jsonEnums = json_model.JsonEnum.parse(jsonDecode(data));
 
       expect(jsonEnums.length, 2);
       expect(jsonEnums[0].name, 'simpleEnum');
@@ -147,7 +147,7 @@ void main() {
           }
         ]
       }]''';
-      var jsonEnum = json_model.JsonEnum.parse(JSON.decode(data)).single;
+      var jsonEnum = json_model.JsonEnum.parse(jsonDecode(data)).single;
 
       expect(jsonEnum.name, 'describedEnum');
       expect(jsonEnum.values.length, 2);
@@ -211,7 +211,7 @@ void main() {
       }]""";
 
       List<json_model.JsonFunction> functions =
-          json_model.JsonFunction.parse(JSON.decode(data));
+          json_model.JsonFunction.parse(jsonDecode(data));
       expect(functions, isNotNull);
       expect(functions, hasLength(1));
       json_model.JsonFunction function = functions[0];