Skip to content

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Dec 1, 2025

Working towards removing the Config extension type. This PR removes all the methods that can be trivially removed.

Not touching importedTypesByUsr, typedefTypeMappings, structTypeMappings, unionTypeMappings, or importedIntegers yet. They're a bit more involved, so I'll do those in a separate PR.

@coveralls
Copy link

coveralls commented Dec 2, 2025

Coverage Status

coverage: 82.352% (+0.4%) from 81.98%
when pulling c221448 on ffigen_config_cleanup_4
into dac4797 on main.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

@liamappelbe liamappelbe changed the title WIP [ffigen] Removing Config extension [ffigen] Remove most of the Config extension Dec 2, 2025
@liamappelbe liamappelbe marked this pull request as ready for review December 2, 2025 00:18
@liamappelbe liamappelbe requested a review from dcharkes December 2, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants