-
Notifications
You must be signed in to change notification settings - Fork 36
[web] update output w/ latest generator #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikeokoronkwo Do we need to ignore this lint for the web package or can it be only for TS gen?
This was because of the single-file examples. We cannot tell when we will need to ignore |
Right, but we already ignore them for the whole Line 22 in 4310354
|
It might be better to do it file-by-file and drop the pkg:web analyzer bit. Just to keep things consistent . |
Yeah, it's a bit odd because we're already inconsistent. We have other ignores in that analysis_options.yaml file but we have an ignore in each of the files for |
I think we can keep that, since we wouldn't necessarily be testing single-file output with already-established web APIs (that'd be suited for something like the current repo) |
You mean keep ignores for At any rate, if we want this per file, that's fine by me, but we should just remove the global ignore in analysis_options.yaml to avoid duplication. |
We might keep it per-file for now, because there's a setting to auto-generate docs for any decl that is part of webref. In the future, we can have such setting an option only enabled for generating |
No description provided.