[ DWDS ] Serve DevTools from DDS by default #2681
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to reduce the number of ways DevTools is served across the ecosystem, we're working on serving DevTools from DDS by default in all tools that spawn DDS. This change exposes some new DDS related configuration options that allow for specifying whether or not DevTools should be served via DDS and whether or not an existing DevTools server should be used. The `devToolsLauncher` parameter has been marked as deprecated as it will be removed in a future major release, but will continue to act as the default way to launch DevTools if it is provided. Other DDS related properties that have been merged into the new `DartDevelopmentServiceConfiguration` class are also marked as deprecated.
github-actions
bot
added
package:dwds
dart-debug-extension
and removed
prepare-release
labels
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
srujzs
approved these changes
Aug 28, 2025
| bool? serveDevTools, | ||
| Uri? devToolsServerAddress, | ||
| }) { | ||
| return DartDevelopmentServiceConfiguration( |
There was a problem hiding this comment.
Is it not valid for a user to pass null for port and devToolsServerAddress and the fields to be set to null?
There was a problem hiding this comment.
Fair point. I'm just going to remove this and reconstruct the DartDevelopmentServiceConfiguration instance manually since this is only relevant until the deprecated properties are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the number of ways DevTools is served across the ecosystem, we're working on serving DevTools from DDS by default in all tools that spawn DDS.
This change exposes some new DDS related configuration options that allow for specifying whether or not DevTools should be served via DDS and whether or not an existing DevTools server should be used.
The
devToolsLauncherparameter has been marked as deprecated as it will be removed in a future major release, but will continue to act as the default way to launch DevTools if it is provided. Other DDS related properties that have been merged into the newDartDevelopmentServiceConfigurationclass are also marked as deprecated.