Skip to content

Support OTP/28 in CI#41

Merged
josevalim merged 1 commit intodashbitco:mainfrom
myfloss:support-elixir-119-in-ci
Mar 4, 2026
Merged

Support OTP/28 in CI#41
josevalim merged 1 commit intodashbitco:mainfrom
myfloss:support-elixir-119-in-ci

Conversation

@kianmeng
Copy link
Copy Markdown
Contributor

@kianmeng kianmeng commented Mar 4, 2026

List of changes:

  • bump GitHub actions
  • bump stream_data to remove deprecation warnings
  • fix test error with OTP 28 not autoloading module
  • specific versions as string and use latest version in CI matrix

List of changes:
- bump GitHub actions
- bump stream_data to remove deprecation warnings
- fix test error with OTP 28 not autoloading module
- specific versions as string and use latest version in CI matrix
# TODO: investigate
def __mix_recompile__?(), do: true

def process_name({:via, registry, {registry_name, name}}, base_name) do
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1) test shutdown server when there is no listener via name (BroadwayDashboard.MetricsTest)
Error:      test/broadway_dashboard/metrics_test.exs:89
     ** (EXIT from #PID<0.381.0>) an exception was raised:
         ** (ArgumentError) expected Broadway to be started with an atom :name, got: {:via, Registry, {BroadwayDashboardTestRegistry, :metrics_test}}

     If starting Broadway with a :name that is not an atom, you must define the process_name/2 callback in the module which calls "use Broadway" (see the documentation).

             (broadway 1.1.0) lib/broadway/topology.ex:490: Broadway.Topology.default_process_name/2
             (broadway 1.1.0) lib/broadway/topology.ex:165: Broadway.Topology.put_terminator/1
             (broadway 1.1.0) lib/broadway/topology.ex:160: Broadway.Topology.init_config/2
             (broadway 1.1.0) lib/broadway/topology.ex:57: Broadway.Topology.init/1
             (stdlib 7.2.1) gen_server.erl:2276: :gen_server.init_it/2
             (stdlib 7.2.1) gen_server.erl:2236: :gen_server.init_it/6
             (stdlib 7.2.1) proc_lib.erl:333: :proc_lib.init_p_do_apply/3

.

  2) test subscribe a process to a pipeline and ask it to refresh stats via name (BroadwayDashboard.MetricsTest)
Error:      test/broadway_dashboard/metrics_test.exs:15
     ** (EXIT from #PID<0.410.0>) an exception was raised:
         ** (ArgumentError) expected Broadway to be started with an atom :name, got: {:via, Registry, {BroadwayDashboardTestRegistry, :metrics_test}}

     If starting Broadway with a :name that is not an atom, you must define the process_name/2 callback in the module which calls "use Broadway" (see the documentation).

             (broadway 1.1.0) lib/broadway/topology.ex:490: Broadway.Topology.default_process_name/2
             (broadway 1.1.0) lib/broadway/topology.ex:165: Broadway.Topology.put_terminator/1
             (broadway 1.1.0) lib/broadway/topology.ex:160: Broadway.Topology.init_config/2
             (broadway 1.1.0) lib/broadway/topology.ex:57: Broadway.Topology.init/1
             (stdlib 7.2.1) gen_server.erl:2276: :gen_server.init_it/2
             (stdlib 7.2.1) gen_server.erl:2236: :gen_server.init_it/6
             (stdlib 7.2.1) proc_lib.erl:333: :proc_lib.init_p_do_apply/3

.............
Finished in 0.6 seconds (0.3s async, 0.3s sync)
1 property, 37 tests, 2 failures (3 excluded)
Error: Process completed with exit code 2.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean tests are failing? But they seem to be passing below?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failed without the changes on Elixir 1.19.

@josevalim josevalim merged commit 8df6b5b into dashbitco:main Mar 4, 2026
3 checks passed
@josevalim
Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

@kianmeng
Copy link
Copy Markdown
Contributor Author

kianmeng commented Mar 4, 2026

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants