Merged
Conversation
List of changes: - bump GitHub actions - bump stream_data to remove deprecation warnings - fix test error with OTP 28 not autoloading module - specific versions as string and use latest version in CI matrix
kianmeng
commented
Mar 4, 2026
| # TODO: investigate | ||
| def __mix_recompile__?(), do: true | ||
|
|
||
| def process_name({:via, registry, {registry_name, name}}, base_name) do |
Contributor
Author
There was a problem hiding this comment.
1) test shutdown server when there is no listener via name (BroadwayDashboard.MetricsTest)
Error: test/broadway_dashboard/metrics_test.exs:89
** (EXIT from #PID<0.381.0>) an exception was raised:
** (ArgumentError) expected Broadway to be started with an atom :name, got: {:via, Registry, {BroadwayDashboardTestRegistry, :metrics_test}}
If starting Broadway with a :name that is not an atom, you must define the process_name/2 callback in the module which calls "use Broadway" (see the documentation).
(broadway 1.1.0) lib/broadway/topology.ex:490: Broadway.Topology.default_process_name/2
(broadway 1.1.0) lib/broadway/topology.ex:165: Broadway.Topology.put_terminator/1
(broadway 1.1.0) lib/broadway/topology.ex:160: Broadway.Topology.init_config/2
(broadway 1.1.0) lib/broadway/topology.ex:57: Broadway.Topology.init/1
(stdlib 7.2.1) gen_server.erl:2276: :gen_server.init_it/2
(stdlib 7.2.1) gen_server.erl:2236: :gen_server.init_it/6
(stdlib 7.2.1) proc_lib.erl:333: :proc_lib.init_p_do_apply/3
.
2) test subscribe a process to a pipeline and ask it to refresh stats via name (BroadwayDashboard.MetricsTest)
Error: test/broadway_dashboard/metrics_test.exs:15
** (EXIT from #PID<0.410.0>) an exception was raised:
** (ArgumentError) expected Broadway to be started with an atom :name, got: {:via, Registry, {BroadwayDashboardTestRegistry, :metrics_test}}
If starting Broadway with a :name that is not an atom, you must define the process_name/2 callback in the module which calls "use Broadway" (see the documentation).
(broadway 1.1.0) lib/broadway/topology.ex:490: Broadway.Topology.default_process_name/2
(broadway 1.1.0) lib/broadway/topology.ex:165: Broadway.Topology.put_terminator/1
(broadway 1.1.0) lib/broadway/topology.ex:160: Broadway.Topology.init_config/2
(broadway 1.1.0) lib/broadway/topology.ex:57: Broadway.Topology.init/1
(stdlib 7.2.1) gen_server.erl:2276: :gen_server.init_it/2
(stdlib 7.2.1) gen_server.erl:2236: :gen_server.init_it/6
(stdlib 7.2.1) proc_lib.erl:333: :proc_lib.init_p_do_apply/3
.............
Finished in 0.6 seconds (0.3s async, 0.3s sync)
1 property, 37 tests, 2 failures (3 excluded)
Error: Process completed with exit code 2.
Member
There was a problem hiding this comment.
Do you mean tests are failing? But they seem to be passing below?
Contributor
Author
There was a problem hiding this comment.
The test failed without the changes on Elixir 1.19.
Member
|
💚 💙 💜 💛 ❤️ |
Contributor
Author
|
🥳 🥳 🥳 🥳 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes: