Skip to content

fix: 쉼표를 포함한 타이틀이더라도 시간과 메모리 정보를 안정적으로 수집하도록 변경#107

Merged
SoMin-Yoo merged 1 commit intomainfrom
hotfix
Feb 2, 2026
Merged

fix: 쉼표를 포함한 타이틀이더라도 시간과 메모리 정보를 안정적으로 수집하도록 변경#107
SoMin-Yoo merged 1 commit intomainfrom
hotfix

Conversation

@utact
Copy link
Collaborator

@utact utact commented Feb 2, 2026

🚀 작업 배경

정규표현식에 허점이 있어 성공 기록을 실패로 취급하는 이슈가 발생했습니다.


🛠️ 주요 변경 사항

  • 타이틀에 쉼표가 포함되어 있더라도 성공/실패를 정상적으로 판단합니다.

🔗 관련 이슈

  • 이메일 제보

@SoMin-Yoo SoMin-Yoo merged commit a7141d8 into main Feb 2, 2026
7 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regex pattern bug in GitHubSubmissionMetadataExtractor that incorrectly treated successful submissions as failures when the problem title contained commas.

Changes:

  • Updated the commit message regex pattern to use non-greedy matching (.+?) instead of non-comma matching ([^,]+) for the title field
  • Added a test case to verify that titles containing commas are correctly parsed

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backend/src/main/java/com/ssafy/dash/github/application/GitHubSubmissionMetadataExtractor.java Changed regex pattern from [^,]+ to .+? for title capture group to support titles with commas
backend/src/test/java/com/ssafy/dash/github/application/GitHubSubmissionMetadataExtractorTest.java Added test case for commit messages with commas in the title (e.g., "큰 놈, 작은 놈, 같은 놈")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@utact utact self-assigned this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants