Conversation
SoMin-Yoo
approved these changes
Feb 2, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a regex pattern bug in GitHubSubmissionMetadataExtractor that incorrectly treated successful submissions as failures when the problem title contained commas.
Changes:
- Updated the commit message regex pattern to use non-greedy matching (
.+?) instead of non-comma matching ([^,]+) for the title field - Added a test case to verify that titles containing commas are correctly parsed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
backend/src/main/java/com/ssafy/dash/github/application/GitHubSubmissionMetadataExtractor.java |
Changed regex pattern from [^,]+ to .+? for title capture group to support titles with commas |
backend/src/test/java/com/ssafy/dash/github/application/GitHubSubmissionMetadataExtractorTest.java |
Added test case for commit messages with commas in the title (e.g., "큰 놈, 작은 놈, 같은 놈") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 작업 배경
정규표현식에 허점이 있어 성공 기록을 실패로 취급하는 이슈가 발생했습니다.
🛠️ 주요 변경 사항
🔗 관련 이슈