Add support for VALUES query #1038
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 79.08% 81.54% +2.45%
==========================================
Files 78 78
Lines 4395 4395
Branches 797 797
==========================================
+ Hits 3476 3584 +108
+ Misses 743 628 -115
- Partials 176 183 +7
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jdye64
approved these changes
Feb 13, 2023
|
@charlesbluca since this is also one of those cases which would benefit from cpu/gpu handling does it make sense to followup on this once #1117 is complete? |
|
Yeah that makes sense - also okay with merging this in as is and iterating on it in my PR if we need VALUES implemented on CPU to unblock something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1013
Initial attempt at supporting the Values query.
Currently limited to creating the result on cpu dataframes only but eventually plan on extending to GPU frames via some common config.