Skip to content

Conversation

@River739
Copy link
Contributor

[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:
<

  1. Fixed invalid regex escape sequence warning in "tests/test_formats.py" by using a raw string.
  2. Made "test_date_formatter_format_value" portable by skipping the test on platforms where "time.tzset()" is not available (e.g., Windows).

@coveralls
Copy link

Coverage Status

coverage: 94.978%. remained the same
when pulling 4f12671 on River739:fix-regex-warning
into 04a130e on data-8:master.

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

docs/_autosummary/
docs/_images/*.png
docs/normal_data.csv
venv/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to not put this change within this PR.

@adnanhemani adnanhemani merged commit 991bc76 into data-8:master Oct 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants