Skip to content

Fix test failure: KeyError: 'textColor' #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aniketsy wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Fix test failure: KeyError: 'textColor' #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/test_maps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ def test_marker_copy():
def test_background_color_condition_white():
# Test the condition when the background color is white (all 'f' in the hex code)
marker = ds.Marker(0, 0, color='#ffffff')
assert marker._folium_kwargs['icon'].options['textColor'], 'gray'
icon_options = marker._folium_kwargs['icon'].options
text_color = icon_options.get('textColor') or icon_options.get('icon_color')
Copy link
Member

@davidwagner davidwagner Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be iconColor instead of icon_color?

Copy link
Contributor Author

@Aniketsy Aniketsy Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll take another look and confirm.

if text_color is not None:
Copy link
Member

@davidwagner davidwagner Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this test should either assert that text_color is 'gray', or assert that it is None, and be specific about which is correct.

Copy link
Contributor Author

@Aniketsy Aniketsy Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, I’ll look into it.

assert text_color == 'gray'
else:
pass

def test_background_color_condition_not_white():
# Test the condition when the background color is not white
Expand Down
Loading