Skip to content

FIX: larger inputs for sorting tests - to test sorts stability #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

FIX: larger inputs for sorting tests - to test sorts stability #390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75cb820
FIX: larger inputs for sorting tests
cakedev0 Oct 19, 2025
8d797c3
for sort too
cakedev0 Oct 19, 2025
ed241bf
add comment about max_side=50
cakedev0 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions array_api_tests/test_sorting_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ def assert_scalar_in_set(
@given(
x=hh.arrays(
dtype=hh.real_dtypes,
shape=hh.shapes(min_dims=1, min_side=1),
shape=hh.shapes(min_dims=1, min_side=1, max_side=50),
# argsort needs to be tested on big enough arrays, hence we set `max_side=50`
# see https://github.com/data-apis/array-api-tests/issues/389
elements={"allow_nan": False},
),
data=st.data(),
Expand Down Expand Up @@ -94,7 +96,9 @@ def test_argsort(x, data):
@given(
x=hh.arrays(
dtype=hh.real_dtypes,
shape=hh.shapes(min_dims=1, min_side=1),
shape=hh.shapes(min_dims=1, min_side=1, max_side=50),
# sort needs to be tested on big enough arrays, hence we set `max_side=50`
# see https://github.com/data-apis/array-api-tests/issues/389
elements={"allow_nan": False},
),
data=st.data(),
Expand Down