Skip to content

Prepare for a release with telemetry on by default #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prepare for a release with telemetry on by default #717

wants to merge 3 commits into from
+12 −5

Conversation

@samikshya-db
Copy link
Contributor

@samikshya-db samikshya-db commented Dec 1, 2025 •
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other : Release

Description

  • Make telemetry is ON by default to track connection stats. This strictly excludes PII, query text, and results.
  • Prepare for release 4.2.2
  • Also updated the documentation to state that 3.8 is not supported.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@samikshya-db samikshya-db marked this pull request as ready for review December 1, 2025 12:52
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

jprakash-db
jprakash-db approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@jprakash-db jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚀 🚀

vikrantpuppala
vikrantpuppala approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@vikrantpuppala vikrantpuppala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! please fix changelog style

CHANGELOG.md
- Circuit breaker changes using pybreaker by @nikhilsuri-db in https://github.com/databricks/databricks-sql-python/pull/705
- perf: Optimize telemetry latency logging to reduce overhead by @samikshya-db in https://github.com/databricks/databricks-sql-python/pull/715
- basic e2e test for force telemetry verification by @nikhilsuri-db in https://github.com/databricks/databricks-sql-python/pull/708
- Telemetry is ON by default to track connection stats. (Note : This strictly excludes PII, query text, and results) by @samikshya-db in https://github.com/databricks/databricks-sql-python/pull/717
Copy link
Contributor

@vikrantpuppala vikrantpuppala Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please format inline with previous changelogs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikrantpuppala vikrantpuppala vikrantpuppala approved these changes

@jprakash-db jprakash-db jprakash-db approved these changes

@nikhilsuri-db nikhilsuri-db Awaiting requested review from nikhilsuri-db

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samikshya-db @vikrantpuppala @jprakash-db