Skip to content

Bumping torch to 2.6 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rithwik-db wants to merge 3 commits into from
+8 −8
Closed

Bumping torch to 2.6 #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6d6136
upgrading torch to 2.6
rithwik-db Mar 6, 2025
07d642c
comment change
rithwik-db Mar 6, 2025
15cb71a
added pull request target
rithwik-db Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr-gpu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- main
- release/*
pull_request_target:
pull_request:
branches:
- main
- release/**
Expand All @@ -21,14 +21,14 @@ jobs:
fail-fast: false
matrix:
include:
- name: "python3.11-pytorch2.5.1-gpus1"
- name: "python3.11-pytorch2.6.0-gpus1"
Copy link
Contributor

@dakinggg dakinggg Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please temp change pull_request_target to pull_request to show CI passing on the 2.5 images. then change back to pull_request_target

gpu_num: 1
python_version: 3.11
container: mosaicml/pytorch:2.5.1_cu124-python3.11-ubuntu20.04
- name: "python3.11-pytorch2.5.1-gpus2"
container: mosaicml/pytorch:2.6.0_cu124-python3.11-ubuntu20.04
- name: "python3.11-pytorch2.6.0-gpus2"
gpu_num: 2
python_version: 3.11
container: mosaicml/pytorch:2.5.1_cu124-python3.11-ubuntu20.04
container: mosaicml/pytorch:2.6.0_cu124-python3.11-ubuntu20.04
steps:
- name: Run PR GPU tests
uses: mosaicml/ci-testing/.github/actions/pytest-gpu@v0.1.2
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# build requirements
[build-system]
requires = ["setuptools < 70.0.0", "torch >= 2.5.1, < 2.5.2"]
requires = ["setuptools < 70.0.0", "torch >= 2.6.0, < 2.6.1"]
build-backend = "setuptools.build_meta"

# Pytest
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
install_requires = [
'numpy>=1.21.5,<2.1.0',
'packaging>=21.3.0,<24.2',
'torch>=2.5.1,<2.5.2',
'triton>=2.1.0',
'torch>=2.6.0,<2.6.1',
'triton>=3.2.0,<3.3.0', # torch 2.6.0 requires ==3.2.0; docker image doesn't have triton installed so installing here.
'stanford-stk==0.7.1',
]

Expand Down
Loading