Skip to content

fix: Add official escapeStringXml stdlib alias#806

Closed
He-Pin wants to merge 1 commit intodatabricks:masterfrom
He-Pin:fix-escape-string-xml-name
Closed

fix: Add official escapeStringXml stdlib alias#806
He-Pin wants to merge 1 commit intodatabricks:masterfrom
He-Pin:fix-escape-string-xml-name

Conversation

@He-Pin
Copy link
Copy Markdown
Contributor

@He-Pin He-Pin commented Apr 28, 2026

Summary

  • add the official std.escapeStringXml spelling alongside the existing std.escapeStringXML alias
  • share the XML escaping implementation between both names
  • update playground completions and add compatibility coverage

Tests

  • ./mill --no-server 'sjsonnet.jvm[3.3.7]'.test
  • ./mill --no-server __.checkFormat

@He-Pin He-Pin marked this pull request as draft April 28, 2026 20:48
@He-Pin
Copy link
Copy Markdown
Contributor Author

He-Pin commented Apr 28, 2026

Closing after checking google/jsonnet's stdlib/std.jsonnet and test_suite/stdlib.jsonnet: the canonical function name is std.escapeStringXML. The lowercase std.escapeStringXml spelling is a documentation-generation mismatch upstream, so sjsonnet should not add this alias here.

@He-Pin He-Pin closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant