Skip to content

perf: specialize Builtin1 and Builtin3 apply paths #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenamar-db merged 1 commit into from
Apr 30, 2026
+13 −0
Merged

perf: specialize Builtin1 and Builtin3 apply paths #807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sjsonnet/src/sjsonnet/Val.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1906,6 +1906,12 @@ object Val {
tailstrictMode: TailstrictMode): Val =
if (namedNames == null && argVals.length == 1) evalRhs(argVals(0).value, ev, outerPos)
else super.apply(argVals, namedNames, outerPos)

override def apply1(argVal: Eval, outerPos: Position)(implicit
ev: EvalScope,
tailstrictMode: TailstrictMode): Val =
if (params.names.length == 1) evalRhs(argVal.value, ev, outerPos)
else super.apply(Array(argVal), null, outerPos)
}

abstract class Builtin2(fn: String, pn1: String, pn2: String, defs: Array[Expr] = null)
Expand Down Expand Up @@ -1949,6 +1955,13 @@ object Val {
if (namedNames == null && argVals.length == 3)
evalRhs(argVals(0).value, argVals(1).value, argVals(2).value, ev, outerPos)
else super.apply(argVals, namedNames, outerPos)

override def apply3(argVal1: Eval, argVal2: Eval, argVal3: Eval, outerPos: Position)(implicit
ev: EvalScope,
tailstrictMode: TailstrictMode): Val =
if (params.names.length == 3)
evalRhs(argVal1.value, argVal2.value, argVal3.value, ev, outerPos)
else super.apply(Array(argVal1, argVal2, argVal3), null, outerPos)
}

abstract class Builtin4(
Expand Down
Loading