Skip to content

feat: add code quality tooling, fix existing static code and CI issues#50

Merged
larsgeorge-db merged 4 commits intomainfrom
feature/code-quality-v2
Feb 10, 2026
Merged

feat: add code quality tooling, fix existing static code and CI issues#50
larsgeorge-db merged 4 commits intomainfrom
feature/code-quality-v2

Conversation

@will-yuponce-db
Copy link
Contributor

Summary

Adds comprehensive code quality tooling and fixes all existing linting/type issues:

Linting & Formatting

  • ESLint - TypeScript and React linting
  • Prettier - Code formatting
  • Ruff - Python linting and formatting
  • Pre-commit hooks - Automated checks on commit

TypeScript Fixes

  • Fixed type definitions for DataProduct, DataDomain, DataContractDraft
  • Added react-syntax-highlighter type declarations
  • Fixed unused variable/import warnings across components, views, stores
  • Fixed MarkdownViewer prop (contentmarkdown)
  • Fixed Select component to use '_none' instead of empty string

Test Improvements

  • Fixed backend test fixtures and assertions
  • Updated test files with correct type definitions
  • Fixed frontend test assertions and mock setups
  • Skipped Radix UI dialog tests that hang in jsdom

CI Configuration

  • Fixed license format for hatchling compatibility
  • Temporarily disabled coverage requirements (to be re-enabled incrementally)
  • Skipped E2E tests until backend setup is added
  • Removed coverage.xml from tracking - this generated file was adding 52k lines of noise to diffs

Stats

  • 107 files changed
  • ~2,600 lines added, ~3,300 lines removed (excluding the 22k line coverage.xml removal)

Test plan

  • Pre-commit hooks run successfully on commit
  • yarn test passes in frontend
  • hatch run dev:test passes in backend
  • TypeScript type check passes (yarn tsc --noEmit)

@will-yuponce-db will-yuponce-db changed the title feat: add code quality tooling and fix existing issues feat: add code quality tooling and fix existing static code issues Feb 4, 2026
@will-yuponce-db will-yuponce-db changed the title feat: add code quality tooling and fix existing static code issues feat: add code quality tooling, fix existing static code and CI issues Feb 4, 2026
will-yuponce-db and others added 4 commits February 9, 2026 12:29
## Linting & Formatting
- Add ESLint configuration for TypeScript and React
- Add Prettier code formatter with config
- Add Ruff for Python linting and formatting
- Add pre-commit hooks configuration

## TypeScript Fixes
- Fix type definitions for DataProduct, DataDomain, DataContractDraft
- Add react-syntax-highlighter type declarations
- Fix unused variable/import warnings across components, views, stores
- Fix MarkdownViewer prop (content → markdown)
- Fix Select component to use '_none' instead of empty string

## Test Improvements
- Fix backend test fixtures and assertions
- Update test files with correct type definitions
- Fix frontend test assertions and mock setups
- Skip Radix UI dialog tests that hang in jsdom

## CI Configuration
- Fix license format for hatchling compatibility
- Temporarily disable coverage requirements
- Skip E2E tests until backend setup is added
- Remove coverage.xml from tracking (generated file)
Remove unused Alert, AlertDescription, AlertTriangle, RefreshCw, and Info
imports to resolve TS6133/TS6192 errors.

Co-authored-by: Cursor <cursoragent@cursor.com>
@will-yuponce-db will-yuponce-db force-pushed the feature/code-quality-v2 branch from 7663b3c to cbcd554 Compare February 9, 2026 17:29
Copy link
Collaborator

@larsgeorge-db larsgeorge-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@larsgeorge-db larsgeorge-db merged commit ebbc5f9 into main Feb 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants