docs: added files and fixed references to docusaurus pages#51
Open
danielrozo-db wants to merge 3 commits intodatabrickslabs:mainfrom
Open
docs: added files and fixed references to docusaurus pages#51danielrozo-db wants to merge 3 commits intodatabrickslabs:mainfrom
danielrozo-db wants to merge 3 commits intodatabrickslabs:mainfrom
Conversation
larsgeorge-db
requested changes
Feb 10, 2026
Collaborator
larsgeorge-db
left a comment
larsgeorge-db
left a comment
There was a problem hiding this comment.
lgtm, just one change needed.
|
|
||
| # local artifacts | ||
| coverage/ | ||
| static/ |
Collaborator
There was a problem hiding this comment.
This would also make the static directory in other places visible. I suggest we be safe here and change this to src/backend/static agt least.
Author
There was a problem hiding this comment.
But wouldn't the .gitignore still ignore the static folder regardless of its location, whether it's on the root or in src/backend/static?
Also, it would require me to update all the relative paths used for images on the website pages. I don't see other repositories, like DQX, doing this.
Have a look: https://github.com/databrickslabs/dqx/tree/main/docs/dqx/static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added files to static folder
Fixed broken references on docs pages
Modified parameters to the docusaurus.config file to point to databircksbabs