Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/test-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,30 @@ jobs:
working-directory: ./src/frontend
run: yarn type-check

frontend-build:
name: Frontend Build Check
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: '24'
cache: 'yarn'
cache-dependency-path: './src/frontend/yarn.lock'

- name: Install dependencies
working-directory: ./src/frontend
run: yarn install --frozen-lockfile

- name: Build frontend
working-directory: ./src/frontend
run: yarn build

coverage-report:
name: Coverage Report
runs-on: ubuntu-latest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,9 @@ export default function UCAssetLookupDialog({
}

const parts = item.id.split('.')
const isCatalog = parts.length === 1 || item.type === UCAssetType.CATALOG || item.type === 'catalog'
const isSchema = parts.length === 2 || item.type === UCAssetType.SCHEMA || item.type === 'schema'
const isColumn = parts.length === 4 || item.type === UCAssetType.COLUMN || item.type === 'column'
const isCatalog = parts.length === 1 || item.type === UCAssetType.CATALOG
const isSchema = parts.length === 2 || item.type === UCAssetType.SCHEMA
const isColumn = parts.length === 4 || item.type === UCAssetType.COLUMN

if (isCatalog) {
const assetInfo: UCAssetInfo = {
Expand Down Expand Up @@ -740,8 +740,8 @@ export default function UCAssetLookupDialog({
const currentSegment = segments[level]

return nodes.filter((node) => {
const isColumn = node.type === UCAssetType.COLUMN || node.type === 'column'
const isCatalogOrSchema = node.type === UCAssetType.CATALOG || node.type === UCAssetType.SCHEMA || node.type === 'catalog' || node.type === 'schema'
const isColumn = node.type === UCAssetType.COLUMN
const isCatalogOrSchema = node.type === UCAssetType.CATALOG || node.type === UCAssetType.SCHEMA
// When selectable via selectableTypes (e.g. catalog/schema), skip allowedTypes filter
if (isNodeSelectable(node.type as UCAssetType) && !isColumn) {
if (!isCatalogOrSchema) {
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/components/search/concepts-search.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ export default function ConceptsSearch({
};

// Navigate to entity detail page
const navigateToEntity = (link: SemanticLink) => {
const navigateToEntity = (link: EnrichedSemanticLink) => {
let path = '';
switch (link.entity_type) {
case 'data_product':
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/components/search/properties-search.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default function PropertiesSearch({

// Assign dialog: target type and selection
const [assignDialogOpen, setAssignDialogOpen] = useState(false);
const [assignTargetType, setAssignTargetType] = useState<'data_contract_property' | 'uc_column'>('');
const [assignTargetType, setAssignTargetType] = useState<'data_contract_property' | 'uc_column' | ''>('');
const [contracts, setContracts] = useState<any[]>([]);
const [selectedContractId, setSelectedContractId] = useState('');
const [selectedSchemaName, setSelectedSchemaName] = useState('');
Expand Down