Skip to content

Added code for CSCwo96334:/tmp directory disk space for snapshot storage #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harinadh-Saladi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added code for CSCwo96334:/tmp directory disk space for snapshot storage #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33d6e4f
Added code for CSCwo96334:/tmp directory disk space for snapshot storage
Harinadh-Saladi Mar 18, 2026
ccd0f7f
Updated fix version
Harinadh-Saladi Mar 23, 2026
9d0d657
Added clarification comment for /tmp snapshot handling
Harinadh-Saladi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions aci-preupgrade-validation-script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2982,17 +2982,19 @@ def scalability_faults_check(**kwargs):


@check_wrapper(check_title="APIC Disk Space Usage (F1527, F1528, F1529 equipment-full)")
def apic_disk_space_faults_check(cversion, **kwargs):
def apic_disk_space_faults_check(cversion, tversion, **kwargs):
result = FAIL_UF
headers = ['Fault', 'Pod', 'Node', 'Mount Point', 'Current Usage %', 'Recommended Action']
data = []
unformatted_headers = ['Fault', 'Fault DN', 'Recommended Action']
unformatted_data = []
doc_url = "https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#apic-disk-space-usage"
# we are checking /tmp utilization because high usage can lead to snaphsot corruption during an upgrade. After the fix version, snapshot storage location moved to /data.
recommended_action = {
'/firmware': 'Remove unneeded images',
'/techsupport': 'Remove unneeded techsupports/cores',
'/data/log': 'Remove unneeded logs in var/log/dme/log'
'/data/log': 'Remove unneeded logs in var/log/dme/log',
'/tmp': 'Remove unneeded logs in /tmp directory'
}
default_action = 'Contact Cisco TAC.'
if cversion.same_as('4.0(1h)') or cversion.older_than('3.2(6i)'):
Expand All @@ -3001,6 +3003,8 @@ def apic_disk_space_faults_check(cversion, **kwargs):
dn_regex = node_regex + r'/.+p-\[(?P<mountpoint>.+)\]-f'
desc_regex = r'is (?P<usage>\d{2,3}%) full'

tmp_faults_skip_versions = ["6.0(9f)", "6.1(4h)", "6.2(1g)"]
tmp_faults_skipped = False # Track if we skip /tmp faults for CSCwo96334 versions
faultInsts = icurl('class',
'faultInst.json?query-target-filter=or(eq(faultInst.code,"F1527"),eq(faultInst.code,"F1528"),eq(faultInst.code,"F1529"))')
for faultInst in faultInsts:
Expand All @@ -3010,14 +3014,24 @@ def apic_disk_space_faults_check(cversion, **kwargs):
fc = faultInst['faultInst']['attributes']['code']
dn = re.search(dn_regex, faultInst['faultInst']['attributes']['dn'])
desc = re.search(desc_regex, faultInst['faultInst']['attributes']['descr'])
if dn and desc:
data.append([fc, dn.group('pod'), dn.group('node'), dn.group('mountpoint'),
if dn:
mountpoint = dn.group('mountpoint')
# CSCwo96334: Skip /tmp faults when target is >= 6.1(4h) or any unaffected versions
if mountpoint == '/tmp' and (not tversion.older_than("6.1(4h)") or any(tversion.same_as(version) for version in tmp_faults_skip_versions)):
tmp_faults_skipped = True
continue
if desc:
data.append([fc, dn.group('pod'), dn.group('node'), dn.group('mountpoint'),
desc.group('usage'),
recommended_action.get(dn.group('mountpoint'), default_action)])
else:
unformatted_data.append([fc, faultInst['faultInst']['attributes']['dn'], default_action])
else:
unformatted_data.append([fc, faultInst['faultInst']['attributes']['dn'], default_action])
if not data and not unformatted_data:
result = PASS
# If we only found /tmp faults that were skipped (CSCwo96334 fixed target versions), return NA
if tmp_faults_skipped:
result = NA
else:
result = PASS
return Result(
result=result,
headers=headers,
Expand Down
90 changes: 90 additions & 0 deletions tests/checks/apic_disk_space_faults_check/Fault_combination.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,95 @@
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1529",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 100% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1529",
"domain": "infra",
"highestSeverity": "critical",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "raised",
"occur": "1",
"origSeverity": "critical",
"prevSeverity": "critical",
"rule": "eqpt-storage-full-critical",
"severity": "critical",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1528",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 89% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1528",
"domain": "infra",
"highestSeverity": "major",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "raised",
"occur": "1",
"origSeverity": "major",
"prevSeverity": "major",
"rule": "eqpt-storage-full-major",
"severity": "major",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "available (Old: 1501496, New: 240908), capUtilized (Old: 79, New: 82), inodesFree (Old: 12148991, New: 12148990), inodesUsed (Old: 721, New: 722), used (Old: 595656, New: 1856244)",
"childAction": "",
"code": "F1527",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /data/log on Node 1 with hostname fab3-apic1 mounted at /data/log is 82% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/data/log]-f-[tmpfs]/fault-F1527",
"domain": "infra",
"highestSeverity": "warning",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "raised",
"occur": "1",
"origSeverity": "warning",
"prevSeverity": "warning",
"rule": "eqpt-storage-full-warning",
"severity": "warning",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
}
]
60 changes: 60 additions & 0 deletions tests/checks/apic_disk_space_faults_check/Fault_exists_not_raised.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,65 @@
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1529",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 100% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1529",
"domain": "infra",
"highestSeverity": "critical",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "retaining",
"occur": "1",
"origSeverity": "critical",
"prevSeverity": "critical",
"rule": "eqpt-storage-full-critical",
"severity": "cleared",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1528",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 89% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1528",
"domain": "infra",
"highestSeverity": "major",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "soaking-clearing",
"occur": "1",
"origSeverity": "major",
"prevSeverity": "major",
"rule": "eqpt-storage-full-major",
"severity": "major",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
}
]
90 changes: 90 additions & 0 deletions tests/checks/apic_disk_space_faults_check/Fault_raised.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,95 @@
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1529",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 100% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1529",
"domain": "infra",
"highestSeverity": "critical",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "raised",
"occur": "1",
"origSeverity": "critical",
"prevSeverity": "critical",
"rule": "eqpt-storage-full-critical",
"severity": "critical",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1528",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 89% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1528",
"domain": "infra",
"highestSeverity": "major",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "raised",
"occur": "1",
"origSeverity": "major",
"prevSeverity": "major",
"rule": "eqpt-storage-full-major",
"severity": "major",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
},

{
"faultInst": {
"attributes": {
"ack": "no",
"alert": "no",
"cause": "equipment-full",
"changeSet": "inodesFree (Old: 12167881, New: 12167880), inodesUsed (Old: 64, New: 65)",
"childAction": "",
"code": "F1527",
"created": "2026-03-13T11:46:02.307+00:00",
"delegated": "no",
"descr": "Storage unit /tmp on node 1 with hostname fab3-apic1 mounted at /tmp is 82% full",
"dn": "topology/pod-1/node-1/sys/ch/p-[/tmp]-f-[tmpfs]/fault-F1527",
"domain": "infra",
"highestSeverity": "warning",
"lastTransition": "2026-03-13T11:48:02.867+00:00",
"lc": "raised",
"occur": "1",
"origSeverity": "warning",
"prevSeverity": "warning",
"rule": "eqpt-storage-full-warning",
"severity": "warning",
"status": "",
"subject": "equipment-full",
"title": "",
"type": "operational"
}
}
}
]
Loading