Add N9300 switch memory check by Priyanka-Patil14 · Pull Request #370 · datacenter/ACI-Pre-Upgrade-Validation-Script

Priyanka-Patil14 · 2026-03-20T12:03:58Z

Summary

This PR adds a new validation check: N9300 Switch Memory.

The check runs only when the target upgrade version is 6.1 and validates that N9300-series switches have at least 24 GB memory before upgrade.

What Changed

Added n9300_switch_memory_check in aci-preupgrade-validation-script.py
Added validation documentation in docs/docs/validations.md
Added dedicated unit tests and test data under:
- tests/checks/n9300_switch_memory_24g_check/

Check Behavior

Returns MANUAL if target version is missing
Returns N/A if target version is not 6.1
Returns N/A if no N9300 switches are present
Returns FAIL_O for N9300 nodes with memory < 24 GB
Returns PASS when all applicable N9300 nodes have >= 24 GB

##Test Validation
Executed:
pytest tests/checks/n9300_switch_memory_24g_check/test_n9300_switch_memory_24g_check.py -q

Result:
7 passed in 0.11s

No failures observed.

Harinadh-Saladi

Pls address the comments

Harinadh-Saladi · 2026-03-23T04:46:19Z

docs/docs/validations.md

 [ISIS DTEPs Byte Size][d27]                     | CSCwp15375   | :white_check_mark: | :no_entry_sign:
 [Policydist configpushShardCont Crash][d28]     | CSCwp95515   | :white_check_mark: | :no_entry_sign:
 [Auto Firmware Update on Switch Discovery][d29] | CSCwe83941   | :white_check_mark: | :no_entry_sign:
+[N9300 Switch Memory][d30]                      | -            | :white_check_mark: | :no_entry_sign:


Pls add bug id, it's missing.

This check is implemented as a general readiness check for N9300-series memory requirements, not tied to a specific CSC bug.

Harinadh-Saladi · 2026-03-23T04:58:05Z

docs/docs/validations.md


+### N9300 Switch Memory
+
+This check applies only when the target upgrade version is 6.1. It reviews `procMemUsage` for N9300-series switches and flags nodes with less than 24GB memory installed.


Pls add the description at the end of the last check. Also, pls mention that this check applies for N9300 series, along with version.

Moved the N9300 description to the end of the check details section and updated the text to clearly mention applicability to N9300-series switches along with the version scope.

Harinadh-Saladi · 2026-03-23T05:08:13Z

tests/checks/n9300_switch_memory_24g_check/test_n9300_switch_memory_24g_check.py

+        # Target version missing
+        (
+            read_data(dir, "fabricNode_one.json"),
+            {


Pls remove target version missing case. It's not required, it will be taken care by the main script.

removed target-version-missing case from this check as requested.

Harinadh-Saladi · 2026-03-23T05:11:18Z

aci-preupgrade-validation-script.py

+    doc_url = 'https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#n9300-switch-memory'
+    min_memory_kb = 24 * 1024 * 1024
+
+    if not tversion:


Pls remove this condition as target version missing check is already taken care by the script.

Removed target-version-missing handling from this check as requested.

asraf-khan · 2026-03-23T05:22:30Z

aci-preupgrade-validation-script.py

+    result = PASS
+    headers = ["NodeId", "Name", "Model", "Memory Detected (GB)"]
+    data = []
+    recommended_action = 'Increase the switch memory to at least 24GB before proceeding with the Cisco ACI software upgrade.'


Just provide recommended_action with what to do. No need to mention about upgrade.

Updated the recommended_action to only state what to do, and removed upgrade-specific wording.

Harinadh-Saladi · 2026-03-23T05:27:18Z

docs/docs/validations.md


+### N9300 Switch Memory
+
+This check applies only when the target upgrade version is 6.1. It reviews `procMemUsage` for N9300-series switches and flags nodes with less than 24GB memory installed.


Pls add about impact of the issue.

Added the impact detail in the docs.

asraf-khan · 2026-03-23T07:26:10Z

@Priyanka-Patil14 please attach test result from APIC for possible scenario's

Priyanka-Patil14 · 2026-03-23T11:14:13Z

Memory_Check_logs.docx

Uploaded the logs.

asraf-khan · 2026-03-23T05:28:30Z

aci-preupgrade-validation-script.py

+    if tversion.major_version != '6.1':
+        return Result(result=NA, msg=VER_NOT_AFFECTED)
+
+    proc_mem_query = 'procMemUsage.json'


No need to use as seperate variable. directly use on icurl as query is small.

Updated as suggested. Removed the separate variable and used the query directly in the icurl call.

asraf-khan · 2026-03-23T05:55:35Z

aci-preupgrade-validation-script.py

+            total_kb = int(total)
+        except ValueError:
+            continue
+


Please check if this try except necessary ?
if so we need to error and update the result accordingly.

Checked this. The try/except is needed, and I updated the code to return an ERROR with details when parsing fails.

asraf-khan · 2026-03-23T05:59:22Z

aci-preupgrade-validation-script.py

+            continue
+        dn_match = re.search(node_regex, mem_dn)
+        if not dn_match:
+            continue


without dn_match & total_kb value not set where we are capturing for particular node/switch ?

is it valid to continue the check ? please check once.

Checked this case, it is not valid to continue when affected node data is missing. Updated the check to return ERROR and include the node details.

asraf-khan · 2026-03-23T06:20:28Z

aci-preupgrade-validation-script.py

+        node_id = node['fabricNode']['attributes']['id']
+        total_kb = node_total_kb.get(node_id)
+        if total_kb is None:
+            continue


without total_kb value not set where we are capturing same for particular node/switch ?

data should be updated and appended accordingly and handle the result.

Updated this part.

asraf-khan · 2026-03-23T06:25:06Z

aci-preupgrade-validation-script.py

+                memory_in_gb,
+            ])
+
+    if result == PASS:


Please handle for ERROR and FAIL_O result cases.

Updated. ERROR and FAIL_O cases are now handled explicitly in the check result flow.

asraf-khan · 2026-03-23T06:25:53Z

aci-preupgrade-validation-script.py

+            ])
+
+    if result == PASS:
+        return Result(result=result)


Not required for PASS result case as we are returning result at the end.

asraf-khan · 2026-03-24T05:47:50Z

aci-preupgrade-validation-script.py



+@check_wrapper(check_title='N9300 Switch Memory')
+def n9300_switch_memory_check(tversion, fabric_nodes, **kwargs):


Add general check at the bottom if it's completely new function as yesterday.

Moved it to the bottom as requested.

asraf-khan · 2026-03-24T10:35:32Z

@Priyanka-Patil14 can you please provide updated script output from APIC and error handling cases?

asraf-khan · 2026-03-24T10:49:38Z

aci-preupgrade-validation-script.py

+        )
+
+    if result == FAIL_O:
+        return Result(result=result, headers=headers, data=data, recommended_action=recommended_action, doc_url=doc_url)


this "return Result" should be common at bottom.

only based on condition validation, update "result" variable as FAIL_O or ERROR.

refer other function for reference.

Updated "return Result()" at the bottom, with conditions checks updating "result" variable as FAIL_O or ERROR."

Priyanka-Patil14 · 2026-03-24T11:06:27Z

@Priyanka-Patil14 can you please provide updated script output from APIC and error handling cases?

MemoryCheck_Logs.txt
APIC_Output_Logs.txt

Uploaded the logs. Please review it.

asraf-khan · 2026-03-24T11:15:50Z

aci-preupgrade-validation-script.py

+                node_id,
+                node['fabricNode']['attributes'].get('name', ''),
+                node['fabricNode']['attributes'].get('model', ''),
+                memory_in_gb,


directly compute "memory_in_gb" using formula inside the if condition to avoid all time compute which is not required.

Moved "memory_in_gb" calculation inside the "if total_kb < min_memory_kb" block.

Priyanka-Patil14 added 2 commits March 20, 2026 16:34

Added N9300 switch memory check

18431a1

Remove unrelated thread/prints changes from N9300 check PR

a0e132a

Harinadh-Saladi reviewed Mar 23, 2026

View reviewed changes

asraf-khan reviewed Mar 23, 2026

View reviewed changes

Harinadh-Saladi reviewed Mar 23, 2026

View reviewed changes

Addressed PR comments

827d36e

asraf-khan suggested changes Mar 24, 2026

View reviewed changes

Addressed and updated n9300_switch_memory_check files

648e8c3

asraf-khan reviewed Mar 24, 2026

View reviewed changes

Updated aci-preupgrade-validation-script.py script

a38bdf8


		### N9300 Switch Memory

		This check applies only when the target upgrade version is 6.1. It reviews `procMemUsage` for N9300-series switches and flags nodes with less than 24GB memory installed.



		@check_wrapper(check_title='N9300 Switch Memory')
		def n9300_switch_memory_check(tversion, fabric_nodes, **kwargs):

Conversation

Priyanka-Patil14 commented Mar 20, 2026

Summary

What Changed

Check Behavior

Uh oh!

Harinadh-Saladi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asraf-khan Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asraf-khan commented Mar 23, 2026

Uh oh!

Priyanka-Patil14 commented Mar 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asraf-khan commented Mar 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Priyanka-Patil14 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asraf-khan Mar 23, 2026 •

edited

Loading

Priyanka-Patil14 commented Mar 24, 2026 •

edited

Loading