Skip to content

Espone i layer profiles in status e inspect #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabrymi93 merged 1 commit into from
Apr 4, 2026
Merged

Espone i layer profiles in status e inspect #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 145 additions & 8 deletions tests/test_cli_inspect_paths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
from toolkit.cli.app import app


def test_inspect_paths_reports_dataset_repo_layout_from_other_cwd(tmp_path: Path, monkeypatch) -> None:
def test_inspect_paths_reports_dataset_repo_layout_from_other_cwd(
tmp_path: Path, monkeypatch
) -> None:
src = Path("project-example")
dst = tmp_path / "project-example"
shutil.copytree(src, dst)
Expand All @@ -30,11 +32,26 @@ def test_inspect_paths_reports_dataset_repo_layout_from_other_cwd(tmp_path: Path
assert result.exit_code == 0, result.output
assert f"config_path: {config_path}" in result.output
assert f"root: {dst / '_smoke_out'}" in result.output
assert f"raw_dir: {dst / '_smoke_out' / 'data' / 'raw' / 'project_example' / '2022'}" in result.output
assert f"raw_manifest: {dst / '_smoke_out' / 'data' / 'raw' / 'project_example' / '2022' / 'manifest.json'}" in result.output
assert f"clean_output: {dst / '_smoke_out' / 'data' / 'clean' / 'project_example' / '2022' / 'project_example_2022_clean.parquet'}" in result.output
assert f"clean_validation: {dst / '_smoke_out' / 'data' / 'clean' / 'project_example' / '2022' / '_validate' / 'clean_validation.json'}" in result.output
assert f"mart_manifest: {dst / '_smoke_out' / 'data' / 'mart' / 'project_example' / '2022' / 'manifest.json'}" in result.output
assert (
f"raw_dir: {dst / '_smoke_out' / 'data' / 'raw' / 'project_example' / '2022'}"
in result.output
)
assert (
f"raw_manifest: {dst / '_smoke_out' / 'data' / 'raw' / 'project_example' / '2022' / 'manifest.json'}"
in result.output
)
assert (
f"clean_output: {dst / '_smoke_out' / 'data' / 'clean' / 'project_example' / '2022' / 'project_example_2022_clean.parquet'}"
in result.output
)
assert (
f"clean_validation: {dst / '_smoke_out' / 'data' / 'clean' / 'project_example' / '2022' / '_validate' / 'clean_validation.json'}"
in result.output
)
assert (
f"mart_manifest: {dst / '_smoke_out' / 'data' / 'mart' / 'project_example' / '2022' / 'manifest.json'}"
in result.output
)
assert "raw_hints:" in result.output
assert "primary_output_file:" in result.output
assert "suggested_read_exists: True" in result.output
Expand All @@ -53,7 +70,16 @@ def test_inspect_paths_json_is_notebook_friendly(tmp_path: Path, monkeypatch) ->

result = runner.invoke(
app,
["inspect", "paths", "--config", str(config_path), "--year", "2022", "--json", "--strict-config"],
[
"inspect",
"paths",
"--config",
str(config_path),
"--year",
"2022",
"--json",
"--strict-config",
],
)

assert result.exit_code == 0, result.output
Expand Down Expand Up @@ -118,7 +144,16 @@ def test_inspect_paths_json_reports_resolved_support_outputs(tmp_path: Path) ->

result = runner.invoke(
app,
["inspect", "paths", "--config", str(config_path), "--year", "2022", "--json", "--strict-config"],
[
"inspect",
"paths",
"--config",
str(config_path),
"--year",
"2022",
"--json",
"--strict-config",
],
)

assert result.exit_code == 0, result.output
Expand All @@ -132,3 +167,105 @@ def test_inspect_paths_json_reports_resolved_support_outputs(tmp_path: Path) ->
str(support_root / "data" / "mart" / "support_ds" / "2024" / "support_table.parquet")
]
assert support_payload["mart"].endswith("support_table.parquet")


def test_inspect_paths_json_exposes_layer_profiles(tmp_path: Path) -> None:
runner = CliRunner()

config_path = tmp_path / "dataset.yml"
root_dir = tmp_path / "out"
config_path.write_text(
"\n".join(
[
f'root: "{root_dir.as_posix()}"',
"dataset:",
' name: "demo_ds"',
" years: [2022]",
"raw: {}",
"clean:",
' sql: "sql/clean.sql"',
"mart:",
" tables:",
' - name: "mart_example"',
' sql: "sql/mart/mart_example.sql"',
]
),
encoding="utf-8",
)

clean_dir = root_dir / "data" / "clean" / "demo_ds" / "2022"
mart_dir = root_dir / "data" / "mart" / "demo_ds" / "2022"
clean_dir.mkdir(parents=True, exist_ok=True)
mart_dir.mkdir(parents=True, exist_ok=True)

(clean_dir / "metadata.json").write_text(
json.dumps(
{
"output_profile": {
"row_count": 39506,
"columns": [
{"name": "comune", "type": "VARCHAR"},
{"name": "reddito", "type": "DOUBLE"},
],
}
},
indent=2,
),
encoding="utf-8",
)
(mart_dir / "metadata.json").write_text(
json.dumps(
{
"clean_input_profile": {
"row_count": 39506,
"columns": [
{"name": "comune", "type": "VARCHAR"},
{"name": "reddito", "type": "DOUBLE"},
],
},
"table_profiles": {
"mart_example": {
"row_count": 7904,
"columns": [
{"name": "comune", "type": "VARCHAR"},
{"name": "totale", "type": "DOUBLE"},
],
}
},
"transition_profiles": [
{
"target_name": "mart_example",
"source_row_count": 39506,
"target_row_count": 7904,
"added_columns": ["totale"],
"removed_columns": ["reddito"],
"type_changes": [{"column": "comune", "from": "VARCHAR", "to": "TEXT"}],
}
],
},
indent=2,
),
encoding="utf-8",
)

result = runner.invoke(
app,
[
"inspect",
"paths",
"--config",
str(config_path),
"--year",
"2022",
"--json",
"--strict-config",
],
)

assert result.exit_code == 0, result.output
payload = json.loads(result.output)
assert payload["layer_profiles"]["clean_output"]["row_count"] == 39506
assert payload["layer_profiles"]["mart_clean_input"]["columns_preview"][0]["name"] == "comune"
assert payload["layer_profiles"]["mart_tables"][0]["name"] == "mart_example"
assert payload["layer_profiles"]["clean_to_mart"][0]["target_name"] == "mart_example"
assert payload["layer_profiles"]["clean_to_mart"][0]["type_change_count"] == 1
Loading
Loading