Urban NY education pr

[shapateriya]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @shapateriya, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a new data ingestion system for New York City's urban education statistics. It enables the automated downloading, processing, and mapping of English Language Arts and Mathematics assessment data, ensuring that a wide range of educational metrics, including test scores, grade levels, and demographic breakdowns, are correctly structured and linked for further analysis and integration.

Highlights

• New Data Import Pipeline: Introduced a complete data import pipeline for Urban New York Education data, covering English Language Arts (ELA) and Mathematics test results.
• Data Acquisition Script: Added a Python script (download.py) to automate the downloading, extraction, filtering, and organization of raw data files from the NYC Department of Education.
• Metadata and Configuration: Included new property-value mapping files (NY_common_pvmap_english.csv, NY_common_pvmap_math.csv), a configuration file (common_metadata.csv), and a manifest file (manifest.json) to define the import process and data structure.
• Place Resolution: Provided a comprehensive place_resolver.csv to map local school identifiers to standardized NCES Data Commons IDs.
• Documentation: Added a README.md file detailing the data source, download instructions, and how to execute the data import process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new data import for New York City education data. The changes include a download script, data processing logic, and various configuration files. I've identified several areas for improvement. The download.py script has a critical bug in its file deletion logic, an inconsistency between its documentation and implementation, and some maintainability issues with hardcoded lists. The place_resolver.csv file is messy, containing many entries with empty DCIDs and numerous duplicates that should be cleaned up. Additionally, the README.md and PV-map files have some inconsistencies and data correctness issues that need to be addressed. My detailed comments and suggestions are provided below.