-
Notifications
You must be signed in to change notification settings - Fork 127
AP IB GT enrollment #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP IB GT enrollment #1774
Conversation
Summary of ChangesHello @HarishC727, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new, automated pipeline for integrating Advanced Placement, International Baccalaureate, and Gifted and Talented enrollment data from the Civil Rights Data Collection. The system includes specialized scripts for downloading and processing data from various years, handling structural differences, and preparing it for statistical variable generation, thereby enriching our educational datasets. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new scripts and configurations for downloading and processing AP, IB, and GT enrollment data. The changes are extensive, adding new functionality for data ingestion. My review focuses on improving script robustness, fixing a critical configuration error, and enhancing documentation clarity. I've identified a critical typo in a configuration file that needs to be addressed. Additionally, I've suggested replacing the use of eval in shell scripts with a safer alternative to prevent potential security vulnerabilities and recommended cleaning up the formatting in the README file for better readability.
statvar_imports/us_urban_school/ap_ib_gt_enrollment/config/gt_enrollment_pvmap.csv
Outdated
Show resolved
Hide resolved
statvar_imports/us_urban_school/ap_ib_gt_enrollment/advanced_placements/run_process.sh
Outdated
Show resolved
Hide resolved
statvar_imports/us_urban_school/ap_ib_gt_enrollment/gifted_and_talented/run_process.sh
Outdated
Show resolved
Hide resolved
statvar_imports/us_urban_school/ap_ib_gt_enrollment/international_baccalaureate/run_process.sh
Outdated
Show resolved
Hide resolved
statvar_imports/us_urban_school/ap_ib_gt_enrollment/download_ap_ib_gt.py
Outdated
Show resolved
Hide resolved
manishvats2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
No description provided.