-
Notifications
You must be signed in to change notification settings - Fork 127
Move version update to cloud workflow #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @vish-cs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the import automation system by centralizing the management of Spanner import job status updates within the Cloud Workflow, rather than the Python Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the Spanner status update logic by moving it from the Python executor to a Google Cloud Workflow. This is a positive architectural change that improves separation of concerns. The simplification of the ImportExecutor constructor is also noted. However, I have identified a critical issue in the updated workflow definition that will cause it to fail on the success path due to missing parameters in a call to a helper function. I have also included a medium-severity comment regarding a design change in the ImportExecutor constructor that negatively impacts testability.
0bd8484 to
7823705
Compare
816657a to
b46e1a0
Compare
64ff6dc to
982ba01
Compare
|
I have also updated the env. var. name to AUTOPUSH_DC_API_KEY in this PR |
No description provided.