Include ephemeral models when dropping orphaned relations #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for orphaned relations to drop, include ephemeral models so potential existing objects are dropped. The edge case is when a model was previously materialized as a table or view and then later changed to ephemeral, the old object never gets cleaned up and remains in the state it was last updated.
Contributor
|
Merged via another PR since I couldnt run CI/CD from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for orphaned relations to drop, include ephemeral models so potential existing objects are dropped. The edge case is when a model was previously materialized as a table or view and then later changed to ephemeral, the old object never gets cleaned up and remains in the state it was last updated. This makes sure that any existing objects will be dropped.