fix(main): honour --agent flag when intercepting --help for schema output#130
Merged
platinummonkey merged 1 commit intomainfrom Feb 27, 2026
Merged
fix(main): honour --agent flag when intercepting --help for schema output#130platinummonkey merged 1 commit intomainfrom
platinummonkey merged 1 commit intomainfrom
Conversation
…tput The help interception in main_inner() checked useragent::is_agent_mode() which only reads environment variables (FORCE_AGENT_MODE, CLAUDECODE, etc.). Because Cli::parse() hasn't run yet at that point, the --agent CLI flag was never visible, so `pup --agent --help` fell through to the normal human-readable clap help instead of the JSON schema. Fix: also detect --agent in the raw args list before parsing, so the intercept fires whenever --agent is present, matching the behaviour of FORCE_AGENT_MODE=1 pup --help. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pup --agent --helpwas outputting human-readable clap help instead of the JSON schema. The--helpintercept inmain_inner()fires beforeCli::parse(), so the--agentCLI flag was invisible touseragent::is_agent_mode()(which only reads env vars). The fix also checks for--agentin the raw args list.Changes
src/main.rs:4834— scan raw args for--agentbeforeCli::parse()runs, so the agent-mode help intercept fires when--agentis present, matchingFORCE_AGENT_MODE=1 pup --helpbehaviourTesting
pup --agent --helpnow produces JSON schema outputdiff <(pup --agent --help) <(FORCE_AGENT_MODE=1 pup --help)returns no differencescargo test)🤖 Generated with Claude Code