Abstract formats and restructure the repo#170
Merged
Conversation
Collaborator
Author
|
The diff is quite big, but the only files you'd like to check are:
|
bolinocroustibat
approved these changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Didn't review everything of course, but the current structure is definitely more readable.
A few remarks (I might add more later):
- if possible, isn't it better not to use relative imports?
- I forgot what exactly is the mechanic behind
proportion(ex-PROPORTION) again. Would be great to explain it in the README (and with a little code comment as well maybe)
maudetes
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to get rid of the current repo structure with
detect_fieldsanddetect_labelsto end up with a unified and cleaner layout. Therefore:Formatclass andFormatsManagerto deal with them (informat.py)formats/folder that contains all formats as single python files, with the format's name as file name (float.py,siren.py, ...)tagsattributelabelsattribute allows to merge fields and labels checks in single files, everything about let's saylatitude_wgsis inlatitude_wgs.pyExample:
This approach will also allow to more easily perform overall additions/modifications (with in mind a new version of #155 with a
parentattribute, which, combined with chunks, should speed up the analysis)