feat(s3): S3 Object Storage via boto3#415
Open
bolinocroustibat wants to merge 1 commit intomainfrom
Open
Conversation
c17238a to
31a5d67
Compare
c3101e5 to
8b3c069
Compare
Pierlou
approved these changes
Apr 16, 2026
Contributor
Pierlou
left a comment
There was a problem hiding this comment.
Thanks for the migration 🙏
b8d92c7 to
8feab42
Compare
Replace the MinIO Python SDK with boto3 and a small S3Client helper (OVH Object Storage and other S3-compatible endpoints). - Config: MINIO_* -> S3_* (endpoint, credentials, buckets); optional S3_*_PREFIX for object key prefix (empty = bucket root). - GeoJSON/PMTiles: parameter upload_to_s3 (formerly upload_to_minio). - Tests mock boto3.resource; test_s3_client covers root vs prefix uploads. Rationale for optional prefixes: briefly dropped in an intermediate iteration, then restored so one bucket can namespace Hydra files (e.g. exports/) without multiplying buckets, while an empty prefix keeps objects at the bucket root. BREAKING CHANGE: Replace MINIO_URL, MINIO_USER, MINIO_PWD, MINIO_*_BUCKET, and MINIO_*_FOLDER with S3_ENDPOINT, S3_ACCESS_KEY_ID, S3_SECRET_ACCESS_KEY, S3_*_BUCKET, and S3_*_PREFIX in config.toml / deployment. Made-with: Cursor
8feab42 to
089abc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes datagouv/data.gouv.fr#2000
Following the move from MinIO to S3-compatible Object Storage, switching MinIO Python SDK to a boto3-based stack.
This introduces
S3Clientwith the same upload contract and public URL shape as before, swaps analysis callers to it, replaces theminiodependency withboto3, and updates tests to mock boto3.