You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix#51
Hello @alexbourret
Maybe the way tofix the issue is not the best.
Could you give me a feedback ?
I will adjust if necessary.
Thanks for your help
Hi @jerometerrier ! Thank you for your contribution !
I made a few modifications in the way the call is made, because according to piwebapi specs the key for boundary type is syncTimeBoundaryType for interpolated data and boundaryType for recorded data.
Also, I have added the boundary type selector to the attribute search connector in retrieve data mode.
We currently don't have a full pi-system instance available for testing. So I have prepared a downloadable beta (v1.2.4-beta.1) for testing. Let me know if you can try it and confirm that the feature is working as expected.
Thank you for your PR and your help !
Hi @alexbourret,
First of all, thank you very much for your responsiveness. 👍
And yes, you are right about the boundary with the interpolated values.
I just tested it locally; the tests I conducted with my version are working with yours.
I’m not able to run all the non-regression tests, but for these parts, it seems to be okay.
Thank you again for your responsiveness! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #51
Hello @alexbourret
Maybe the way tofix the issue is not the best.
Could you give me a feedback ?
I will adjust if necessary.
Thanks for your help