Bug/sc 229162 missing timestamps#66
Merged
alexbourret merged 3 commits intofeature/sc-227482-interpolated-values-for-event-framesfrom Mar 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Works fine, due to the simple change in python-lib/osisoft_plugin_common.py
But the PR has loads of changes to do with adding boundary_type which I guess came from another PR - not sure why they are showing in the diff or if they should be in here at all...?
Ah I remember now - was due to this:
#55 (review)
alexbourret
merged commit df49ec4
into
feature/sc-227482-interpolated-values-for-event-frames
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/dataiku/story/229162