-
Notifications
You must be signed in to change notification settings - Fork 22
Migrate from TinyMCE to TipTap #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 70 70
Lines 4755 4755
=======================================
Hits 3809 3809
Misses 946 946 🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bc/migrate-to-tiptap
|
Run status |
|
Run duration | 07m 36s |
Commit |
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
336
|
View all changes introduced in this branch ↗︎ |
Hey @jdbocarsly, as discussed last week in the PR using QuillJS, cross-referencing (should) work in this PR if you want to test it. I think I'm going to abandon QuillJS in favour of Tiptap to replace TinyMCE. |
This is really slick! Thanks for doing this. The @ tagging is really smooth, and I really like the mermaid editor! A few notes:
|
75b87c4
to
015ce86
Compare
Closes #1232
Duplicate of the PR #1343 , but this one uses Tiptap and supports all the basic features of TinyMCE.
Perhaps it would be easier to merge the two to compare Quill and Tiptap? After trying both, TipTap seems more robust for the long term.
This PR already support:
TinyMCEInline.vue