Merged
Conversation
Contributor
Author
|
mhh, highly relevant topic, but also 2 years old already :( I'll turn it into a draft. probably i'll come back in a year to close it |
jsheunis
reviewed
Jul 18, 2025
jsheunis
reviewed
Jul 18, 2025
jsheunis
reviewed
Jul 18, 2025
jsheunis
reviewed
Jul 18, 2025
Co-authored-by: Stephan Heunis <s.heunis@fz-juelich.de>
…book into external_collaboration
mih
reviewed
Jul 21, 2025
Co-authored-by: Michael Hanke <michael.hanke@gmail.com>
as per mih's suggestion
jennaswa
reviewed
Jul 22, 2025
Contributor
jennaswa
left a comment
jennaswa
left a comment
There was a problem hiding this comment.
Thanks, @adswa! I enjoyed reading this chapter. Here are some suggested edits, mostly to add a bit of clarity around the host data provider versus external collaborator in some places. While reading, I also wondered if adding a few more headings to the toy example could help reference back to important steps for readers like me that like bullet points and lists (as opposed to long text). Otherwise, there are a bunch of super minor grammar/spelling suggestions for consistency throughout.
Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Update docs/usecases/external_collaboration.rst Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
adswa
force-pushed
the
external_collaboration
branch
from
f81e588 to
67ec3b6
Compare
Contributor
Author
|
Thanks all for the extensive review this has gotten. I've pushed a few final changes and will merge once CI has turned green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wants to fix #233 when it's grown-up.
Currently, this only sketches the problem-space of the use case proposed in #233. A future step-by-step needs to detail the actual implementation.