Add --assume-ready for image and extra-inputs#205
Add --assume-ready for image and extra-inputs#205bpinsard wants to merge 6 commits intodatalad:masterfrom
Conversation
|
Code Climate has analyzed commit 380ead9 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 93.88% 94.07% +0.18%
==========================================
Files 24 24
Lines 1112 1147 +35
==========================================
+ Hits 1044 1079 +35
Misses 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
left a comment
There was a problem hiding this comment.
Left some minor recommendations but overall I think it should be ok.
But now it would need some basic test added since code with tests is ... broken code ;) See e.g. recently added tests for extra_inputs handling in https://github.com/datalad/datalad-container/blob/HEAD/datalad_container/tests/test_run.py#L195
|
I will move it to Draft. Please bring it back to "Ready for Review" whenever it gets extended with a test @bpinsard . |
|
ping @bpinsard any time to finish this one up? |
a429479 to
a7686a5
Compare
39bada2 to
93267c9
Compare
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
380ead9 to
037de79
Compare
|
Speed by merged |
Add
--assume-readyoption to be passed torun, with extra options forimageandextra-inputs.see #199 .
TODOs