Skip to content

Update #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mih wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9ba350
rf: homogenize deprecation pattern for `datalad_next.iterools`
mih Oct 30, 2024
5961e47
rf: homogenize deprecation pattern for `datalad_next.iterable_subproc…
mih Oct 30, 2024
b636124
rf: import `PRE_INIT_COMMIT_SHA` from `datalad_core`
mih Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion datalad_next/consts/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@
``True`` if executed on the Windows platform.
"""

__all__ = [
'COPY_BUFSIZE',
'PRE_INIT_COMMIT_SHA',
'on_linux',
'on_windows',
]

# import from "utils", but these really are constants
from datalad.utils import (
on_linux,
Expand All @@ -29,4 +36,4 @@
# from PY3.10
COPY_BUFSIZE = 1024 * 1024 if on_windows else 64 * 1024

from datalad.consts import PRE_INIT_COMMIT_SHA
from datalad_core.consts import PRE_INIT_COMMIT_SHA
15 changes: 12 additions & 3 deletions datalad_next/iterable_subprocess/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"""Context manager to communicate with a subprocess using iterables

.. deprecated:: 1.6

This code has been moved to the datasalad library.
Use it from ``datasalad.iterable_subprocess`` instead.
This module is deprecated. It has been migrated to the `datasalad library
<https://pypi.org/project/datasalad>`__. Imports should be adjusted to
``datasalad.iterable_subprocess``.

This offers a higher level interface to subprocesses than Python's built-in
subprocess module, and is particularly helpful when data won't fit in memory
Expand All @@ -22,4 +22,13 @@

__all__ = ['iterable_subprocess']

import warnings

from datasalad.iterable_subprocess import iterable_subprocess

warnings.warn(
'`datalad_next.iterable_subprocess` has been migrated to the datasalad '
'library, adjust imports to `datasalad.iterable_subprocess`',
DeprecationWarning,
stacklevel=1,
)
17 changes: 13 additions & 4 deletions datalad_next/itertools/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"""Various iterators, e.g., for subprocess pipelining and output processing

.. deprecated:: 1.6

This code has been moved to the datasalad library.
Use it from ``datasalad.itertools`` instead.
This module is deprecated. It has been migrated to the `datasalad library
<https://pypi.org/project/datasalad>`__. Imports should be adjusted to
``datasalad.itertools``.
"""

__all__ = [
Expand All @@ -17,13 +17,22 @@
'route_out',
]

import warnings

from datasalad.itertools import (
StoreOnly,
align_pattern,
decode_bytes,
itemize,
load_json,
load_json_with_flag,
route_in,
route_out,
StoreOnly,
)

warnings.warn(
'`datalad_next.itertools` has been migrated to the datasalad library, '
'adjust imports to `datasalad.itertools`',
DeprecationWarning,
stacklevel=1,
)
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ classifiers = [
dependencies = [
"annexremote",
"datalad >= 0.18.4",
"datalad-core",
"datasalad >= 0.5.0",
"humanize",
"more-itertools",
Expand Down
Loading