Draft
Conversation
Member
Author
|
@yarikoptic It is not clear to me why the patch would not apply -- it does for me locally, and it only adds files. Please advice. Update: Applying the patch only fails on windows. The very same patch (against the same sources?) applies cleanly on macos and ubuntu. |
Member
5e667f2 to
0a3cc9f
Compare
Apparently git is touchy to line endings on Windows while applying patches, so we will just modify them in place on windows to guarantee correct ending
added 4 commits
May 6, 2025 16:41
=== Do not change lines below ===
{
"chain": [
"47fa1b854c9e94abc0fe7aadb8df8a8cd6525808",
"ff26f850198044041285400f56f451b5a76d95d3",
"424897650eadcbf7c13636064073bde0df7a6eda"
],
"cmd": "make -C .github/workflows/template",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…ws stopped working
Member
|
this is confusing... it was working ok in some TEMP implementations where I had unix2dos call before applying the patches, and it worked. but now it stopped, uff... dunno ATM. Might later troubleshoot directly in github actions using https://github.com/mxschmitt/action-tmate . At least I added installation/invocation of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is WiP. Posting now to see if anything re actions integration would work. The packaging itself has been tested on linux and windows already.