Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the previously composed jupyter-mcp-server integration and refocuses earthdata-mcp-server on Earthdata-only capabilities, adding explicit download “modes” and updating docs/examples accordingly.
Changes:
- Removed
jupyter-mcp-serverdependency and all runtime/notebook composition logic from the server/CLI. - Reworked
download_earth_data_granulesintomanifest/download/scriptmodes and documented the intended composition pattern viamcp-compose. - Updated README/docs/examples/tests to reflect the Earthdata-only scope.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Removes Jupyter composition messaging; documents Earthdata-only features and new download modes. |
pyproject.toml |
Drops jupyter-mcp-server dependency; simplifies test extras to pytest. |
Makefile |
Removes Jupyter-related CLI flags from the start target messaging/command. |
earthdata_mcp_server/server.py |
Deletes Jupyter composition + routes; adds download modes, manifest shaping, and script generation. |
earthdata_mcp_server/__main__.py |
Switches python -m earthdata_mcp_server to invoke the Click command group. |
docs/download.md |
New documentation for download modes and composition strategy with mcp-compose. |
docs/authentication.md |
Links authentication guidance to the new download workflow doc. |
earthdata_mcp_server/tests/test_composition.py |
Replaces composition checks with Earthdata-only “smoke” checks. |
earthdata_mcp_server/tests/test_cli_options.py |
Simplifies CLI checks to start command/options. |
earthdata_mcp_server/tests/README.md |
Updates test documentation to Earthdata-only smoke tests. |
earthdata_mcp_server/tests/__init__.py |
Updates package docstring; retains star imports of tests. |
earthdata_mcp_server/examples/workflow_example.py |
Replaces composed notebook example with Earthdata-only manifest/script flow. |
earthdata_mcp_server/examples/README.md |
Updates example documentation to match Earthdata-only workflow. |
earthdata_mcp_server/examples/__init__.py |
Updates module docstring for Earthdata-only examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.