Improve data download and process workflow #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! |
Contributor
Author
Thanks for the fast approval. I'll add some comments for traceability. |
Member
|
You are welcome 👍! |
wiki0831
commented
Apr 10, 2025
| if [ ! -f ne_10m_admin_0_countries.zip ]; then curl -L -o ne_10m_admin_0_countries.zip https://naciscdn.org/naturalearth/10m/cultural/ne_10m_admin_0_countries.zip; fi | ||
|
|
||
| data: download | ||
| ogr2ogr -f GeoJSON -makevalid -lco COORDINATE_PRECISION=6 -sql "SELECT admin as name, iso_a3 as \"ISO3166-1-Alpha-3\", iso_a2 as \"ISO3166-1-Alpha-2\" FROM ne_10m_admin_0_countries" data/countries.geojson /vsizip/ne_10m_admin_0_countries.zip |
Contributor
Author
There was a problem hiding this comment.
why makevalid
the original geojson from NaturalEarth contain invalid geometry features and this flag auto correct the invalid features.
also fixes:
example:
Contributor
Author
There was a problem hiding this comment.
why "COORDINATE_PRECISION=6"
source dataset from natural earth is at 10m res and 6 decimal place is sufficient
reducing to 6th decimal also reduces the file size.
re:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
makevalidoptionsNotes:
data update is not included in the commit, but will be triggered by Actions