Use EH iso codes from NaturalEarth #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natural Earth does not provide ISO codes for some large countries, in particular France and Norway. This is a conscious decision that is rooted in an imprecise or overlapping definition of country codes by ISO, where Natural Earth follows a stricter mode that is more fine grained. For users who are ok with an imprecise definition and who would need the ISO code for Paris's geo coordinates to be "FR" rather than "-99", they provide the ISO_EH fields (fuzzy fields). This commit addresses this issue by switching to the "EH" fields and recreates the dataset, replacing some of the "-99" values with the commonly accepted ISO codes. Context for this issue is upstream at nvkelso/natural-earth-vector#268 This has been discussed for this codebase before, and is currently in regression datasets#6
|
I got caught by this issue recently. Are you able to take a look at merging this @gradedSystem? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natural Earth does not provide ISO codes for some large countries, in particular France and Norway. This is a conscious decision that is rooted in an imprecise or overlapping definition of country codes by ISO, where Natural Earth follows a stricter mode that is more fine grained.
For users who are ok with an imprecise definition and who would need the ISO code for Paris's geo coordinates to be "FR" rather than "-99", they provide the ISO_EH fields (fuzzy fields).
This commit addresses this issue by switching to the "EH" fields and recreates the dataset, replacing some of the "-99" values with the commonly accepted ISO codes.
Context for this issue is upstream at nvkelso/natural-earth-vector#268
This has been discussed for this codebase before, and is currently in regression #6