Allow ffmpeg 8.x, update from pyffmpeg to typed-ffmpeg#618
Open
Jakan-Kink wants to merge 2 commits intodatawhores:dev/3.14from
Open
Allow ffmpeg 8.x, update from pyffmpeg to typed-ffmpeg#618Jakan-Kink wants to merge 2 commits intodatawhores:dev/3.14from
Jakan-Kink wants to merge 2 commits intodatawhores:dev/3.14from
Conversation
Replace raw subprocess calls with ffmpeg-python's fluent API for DRM decryption and audio/video muxing. Removes the overly conservative ffmpeg <8 version pin (decryption_key is stable through ffmpeg 8.x), fixes an undefined variable bug in verify_media_integrity's success log path, and corrects two invalid regex escape sequences.
Author
|
I downloaded 10 videos with this patch installed that all downloaded and went through the Widevine DRM pipeline. |
Switch from the unmaintained ffmpeg-python (last release 2019) to
typed-ffmpeg, an actively maintained fork with full type annotations,
zero runtime dependencies, and no CVE-carrying `future` dep.
API adjustments:
- positional filename → keyword `filename=`
- arbitrary kwargs (movflags, decryption_key) → `extra_options={}`
- ffmpeg.Error → ffmpeg.FFMpegExecuteError
- probe() uses explicit show_format/show_streams params
- removed unused ffmpeg import from ffmpeg.py
Jakan-Kink
changed the title
Author
|
Jakan-Kink
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace raw subprocess calls with ffmpeg-python's fluent API for DRM decryption and audio/video muxing. Removes the overly conservative ffmpeg <8 version pin (decryption_key is stable through ffmpeg 8.x), fixes an undefined variable bug in verify_media_integrity's success log path, and corrects two invalid regex escape sequences.