Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Comments

index.js: use app argument instead of this.app#104

Open
jonathanong wants to merge 2 commits intodavewasmer:masterfrom
jonathanong:patch-1
Open

index.js: use app argument instead of this.app#104
jonathanong wants to merge 2 commits intodavewasmer:masterfrom
jonathanong:patch-1

Conversation

@jonathanong
Copy link

@jonathanong jonathanong commented Aug 21, 2017

fixes #103

@davewasmer
Copy link
Owner

@jonathanong would you mind linking to the docs that describe app.app here? I'd love to understand a bit more about why this change is necessary.

@jeffjewiss
Copy link

I don't know if this is well documented, but I'm pretty sure the issue here is related to nesting add-ons. Since add-ons can be nested n levels deep, the reference to app could mean the user's application, or it could mean a parent add-on.

The fix in this PR has been used in several add-ons to ensure that the correct configuration is being referenced. Here is another example: rwjblue/ember-cli-pretender@dda9bf8

It should be safe to merge this once the tests are fixed. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot be used within addons: Cannot read property 'env' of undefined

3 participants