This repository was archived by the owner on Aug 15, 2019. It is now read-only.
index.js: use app argument instead of this.app#104
Open
jonathanong wants to merge 2 commits intodavewasmer:masterfrom
jonathanong:patch-1
Open
index.js: use app argument instead of this.app#104jonathanong wants to merge 2 commits intodavewasmer:masterfrom jonathanong:patch-1
jonathanong wants to merge 2 commits intodavewasmer:masterfrom
jonathanong:patch-1
Conversation
Owner
|
@jonathanong would you mind linking to the docs that describe |
|
I don't know if this is well documented, but I'm pretty sure the issue here is related to nesting add-ons. Since add-ons can be nested n levels deep, the reference to The fix in this PR has been used in several add-ons to ensure that the correct configuration is being referenced. Here is another example: rwjblue/ember-cli-pretender@dda9bf8 It should be safe to merge this once the tests are fixed. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #103