This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Wrap initializer in fastboot check#111
Open
jeffjewiss wants to merge 1 commit intodavewasmer:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you try to use this add-on with an app that has Fastboot enabled it will throw an error and refuse to render anything due to the use of
document. One of the suggested updates to support Fastboot, specifically for initializers, is to wrap them in a check for the existance of Fastboot.While there is likely further work to be done to support Fastboot, I think this is a good first step.