add strType == "traced" compatibility#18
Open
skelly001 wants to merge 1 commit intodavidcsterratt:masterfrom
Open
add strType == "traced" compatibility#18skelly001 wants to merge 1 commit intodavidcsterratt:masterfrom
skelly001 wants to merge 1 commit intodavidcsterratt:masterfrom
Conversation
Owner
|
Thank you for this commit. I'm wondering if it would be possible for you to add a test case for the code. You'd need to
If this is too much, don't worry - I've not got tests for all types as it stands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found my imageJ (Fiji) ROI file data has strType == "traced", which was not included in ij2spatstat(). This added functionality allows for generation of the desired psp object (tested on my own data)