fix typo in 7baa28ecd272eba30edd61fd7ee257ba4d160615#77
Open
mayaylagan242 wants to merge 1 commit intodavidcsterratt:masterfrom
Open
fix typo in 7baa28ecd272eba30edd61fd7ee257ba4d160615#77mayaylagan242 wants to merge 1 commit intodavidcsterratt:masterfrom
mayaylagan242 wants to merge 1 commit intodavidcsterratt:masterfrom
Conversation
Owner
|
Many thanks for your pull request, and sorry for the delay replying. I've been overwhelmed with work, and I am struggling to find the time to do the relevant testing, in particular the reverse dependencies. If you (or anyone else) has time to do this, that would speed up the process. See also [#81]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this typo causing a breaking change in packages that depend on this one. The case that was causing this issue was when
delaunayn()was called with onlypand no other args. In my minimal testing this fixed the breaking change.