Missed some changes to ClojureScript#14
Missed some changes to ClojureScript#14ILoveHubGit wants to merge 16 commits intodaviddpark:masterfrom
Conversation
|
Thanks for the library updates! Interesting, because the unit tests passed when I ran them from your code. Run Taking a look now. |
|
Correct. For me the unit tests worked also. I'm working on another update so it is possible to run all tests also against ClojureScript. |
|
Sorry it took some extra time to solve the problems I ran into. I added a test in which a vector contains multiple maps of which two are changed. This was the JSON part that went wrong in my previous tests. To solve this I changed the order of the condition in the function diff-vecs. Thanks for your patience. |
|
At last I succeeded in adding also the unit tests for ClojureScript. I only implemented the tests that were in core_test.clj because the function tested in the other functions are already tested via Clojure (lein midje). I would love to see this merged with your library. |
Sorry but with my previous pull request I broke your library. Here an update.
I think that I was somewhat to eager in solving the conflicts.
Hope I did a better job this time.
I now ran the tests within a REPL, because on my PC
lein testdoes not seem to work as no test is run then.